otelhttp: export Event type for WithMessageEvents #8153
Conversation
|
Hello @dmathieu , OpenTelemetry Go enums usually prefix constants with the type name (e.g. SpanKindServer, SpanKindClient). So shall I change |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8153 +/- ##
=====================================
Coverage 81.8% 81.8%
=====================================
Files 194 194
Lines 13362 13362
=====================================
+ Hits 10936 10937 +1
+ Misses 2029 2027 -2
- Partials 397 398 +1
🚀 New features to boost your workflow:
|
sonalgaud12
force-pushed
the
otelhttp
branch
from
33a327d to
ae43cdd
Compare
|
|
||
| func TestEvent(t *testing.T) { | ||
| if otelhttp.ReadEvents != 1 { | ||
| t.Errorf("ReadEvents = %v, want 1", otelhttp.ReadEvents) |
There was a problem hiding this comment.
Can we uniformly adopt the assert.Equal method for assertions.
Additionally, we lack tests for unspecifiedEvent.
| t.Errorf("WriteEvents = %v, want 2", otelhttp.WriteEvents) | ||
| } | ||
|
|
||
| if got := otelhttp.WithMessageEvents(otelhttp.ReadEvents); got == nil { |
There was a problem hiding this comment.
I'm not quite sure what this verifies.
There was a problem hiding this comment.
This verifies that the exported ReadEvents and WriteEvents values are valid for WithMessageEvents and return a proper non-nil. Is there any improvement I should make or remove this part?
There was a problem hiding this comment.
Subtests would be clearer there.
3 participants
This PR fixes issue #8132
The WithMessageEvents option previously accepted an unexported type (event).
This change exports the type as Event.